Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254269

Re: [PATCH -next] mtd: fsl-quadspi: Never build on SPARC

Show all headers | View raw

On 10/22/2015 06:07 PM, Brian Norris wrote:
> + Han
>
> On Wed, Oct 21, 2015 at 07:31:46AM -0700, Guenter Roeck wrote:
>> Attempts to build fsl-quadspi on SPARC fail with
>>
>> drivers/mtd/spi-nor/fsl-quadspi.c: In function 'fsl_qspi_init_lut':
>> drivers/mtd/spi-nor/fsl-quadspi.c:369:1: error:
>> 	'LUT_0' undeclared (first use in this function)
>> drivers/mtd/spi-nor/fsl-quadspi.c:418:1: error:
>> 	pasting "LUT_" and "(" does not give a valid preprocessing token
>> drivers/mtd/spi-nor/fsl-quadspi.c:418:2: error:
>> 	implicit declaration of function 'LUT_'
>
> I don't think this is only a SPARC problem. The macro concatenation is
> generally suspect.
>
> I see that READ and WRITE are problems at least. If something like
> <linux/fs.h> gets included somehow, then these tokens resolve to
> integers or expressions before they fall through to literal
> concatentation, so we get 'LUT_0' or 'LUT_(1ULL << __REQ_WRITE)' instead
> of 'LUT_READ' and 'LUT_WRITE'.
>
You are right, that deserves a better fix. I'll leave it up to you.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] mtd: fsl-quadspi: Never build on SPARC Guenter Roeck <linux@roeck-us.net> - 2015-10-21 16:40 +0200
  Re: [PATCH -next] mtd: fsl-quadspi: Never build on SPARC Brian Norris <computersforpeace@gmail.com> - 2015-10-23 03:10 +0200
    Re: [PATCH -next] mtd: fsl-quadspi: Never build on SPARC Guenter Roeck <linux@roeck-us.net> - 2015-10-23 03:20 +0200
      Re: [PATCH -next] mtd: fsl-quadspi: Never build on SPARC Han Xu <xhnjupt@gmail.com> - 2015-10-23 18:40 +0200
        Re: [PATCH -next] mtd: fsl-quadspi: Never build on SPARC Brian Norris <computersforpeace@gmail.com> - 2015-10-23 19:00 +0200
        Re: [PATCH -next] mtd: fsl-quadspi: Never build on SPARC Guenter Roeck <linux@roeck-us.net> - 2015-10-23 19:00 +0200

csiph-web