Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254065

Re: [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret returning 0

Show all headers | View raw

On Thu, Oct 22, 2015 at 3:16 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 10/21/2015 05:55 PM, Punit Vara wrote:
>
>> This patch is to the ath5k/eeprom.c that fixes up warning caught by
>> coccicheck:
>>
>> Unneeded variable: "ret". Return "0" on line 980
>>
>> Remove unneeded variable ret created to return zero.
>>
>> Signed-off-by: Punit Vara <punitvara@gmail.com>
>> ---
>>   drivers/net/wireless/ath/wcn36xx/main.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c
>> b/drivers/net/wireless/ath/wcn36xx/main.c
>> index 7c169ab..82982d5 100644
>> --- a/drivers/net/wireless/ath/wcn36xx/main.c
>> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
>> @@ -935,7 +935,6 @@ static const struct ieee80211_ops wcn36xx_ops = {
>>
>>   static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
>>   {
>> -       int ret = 0;
>>
>
>   This empty line should be removed too.
>
>>         static const u32 cipher_suites[] = {
>>                 WLAN_CIPHER_SUITE_WEP40,
>
> [...]
>
> MBR, Sergei
>
I have resend this patch as you said Sergei . Thanks for feedback ..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/15] Fix warnings reported by coccicheck Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
  [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
    Re: [PATCH 08/15] net: wireless: simplify return flow for  usb_control_msg Jiri Slaby <jslaby@suse.cz> - 2015-10-21 17:10 +0200
      Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg punit vara <punitvara@gmail.com> - 2015-10-21 20:10 +0200
  [PATCH 02/15] net: wireless: ath: Remove unnecessary semicolon Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
  [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret returning 0 Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
    Re: [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret  returning 0 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-21 23:50 +0200
      Re: [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret  returning 0 punit vara <punitvara@gmail.com> - 2015-10-22 20:30 +0200
  [PATCH 09/15] net: wireless: simplify return flow for zd1201_setconfig16 Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
  [PATCH 10/15] net: wireless: ath: simplify return flow for carl9170_regwrite_result() Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
  [PATCH 03/15] net: wireless: ath: Remove unnecessary semicolon Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
  [PATCH 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
  [PATCH 12/15] net: wireless: brcm80211: Remove unneeded variable which return 0 Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
  [PATCH 13/15] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0 Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
  Re: [PATCH 01/15] net: wireless: ath: use | instead of + for summing  bitmasks Jiri Slaby <jirislaby@gmail.com> - 2015-10-21 17:00 +0200
  [PATCH 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
  [PATCH 04/15] net: wireless: ipw2x00: use | instead of + for summing bitmasks Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
  [PATCH 11/15] net: wireless: iwlegacy: Remove unneeded variable ret Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
    Re: [PATCH 11/15] net: wireless: iwlegacy: Remove unneeded variable  ret Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-21 23:50 +0200
  [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
    Re: [PATCH 01/15] net: wireless: ath: use | instead of + for summing  bitmasks Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-21 23:50 +0200
      Re: [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks punit vara <punitvara@gmail.com> - 2015-10-22 20:30 +0200
  [PATCH 06/15] net: wireless: rtwifi: Remove duplicated arguments to | Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200
  [PATCH 07/15] net: wireless: brcm80211: Remove duplicated arguments to | Punit Vara <punitvara@gmail.com> - 2015-10-21 17:00 +0200

csiph-web