Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1250827

Re: [RFC PATCH v3 4/4] drm/armada: Convert the probe function to the generic drm_of_component_probe()

Show all headers | View raw

On Mon, Oct 19, 2015 at 04:17:14PM +0100, Russell King - ARM Linux wrote:
> On Mon, Oct 19, 2015 at 04:07:50PM +0100, Liviu Dudau wrote:
> > The armada DRM driver keeps some old platform data compatibility in the
> > probe function that makes moving to the generic drm_of_component_probe()
> > a bit more complicated that it should. Refactor the probe function to do
> > the platform_data processing after the generic probe (and only if that
> > fails). This way future cleanup can further remove support for it.
> 
> I'm mainly using the old code, even with DT based platforms, because it
> needs a block of reserved memory which I haven't got around to converting
> to DT stuff (each time I've looked into doing that, bits for dealing with
> reserved memory nodes were missing.)

Thanks for explaining this!

> 
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

And thanks for all the ACKs!

Best regards,
Liviu

> 
> -- 
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH v3 4/4] drm/armada: Convert the probe function to the generic drm_of_component_probe() Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-19 17:10 +0200
  Re: [RFC PATCH v3 4/4] drm/armada: Convert the probe function to the  generic drm_of_component_probe() Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-19 17:20 +0200
    Re: [RFC PATCH v3 4/4] drm/armada: Convert the probe function to the  generic drm_of_component_probe() Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-19 17:30 +0200

csiph-web