Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1250383

Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency

Show all headers | View raw

Hi Magnus,

Thank you for the patch.

On Monday 19 October 2015 12:02:53 Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
> 
> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE
> nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get
> rid of the dependency.
>
> Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using:
>  # CONFIG_ARM_LPAE is not set

The driver only supports the 40-bits page table format for now, hence the 
dependency on LPAE, but it indeed seems that the dependency is bogus. As long 
as the 8 MSBs of the translated address are all 0 I assume the output 40-bit 
address is usable on a 32-bit physical address system.

How have you tested the patch ?

> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
> 
>  drivers/iommu/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- 0001/drivers/iommu/Kconfig
> +++ work/drivers/iommu/Kconfig	2015-10-18 14:58:09.080513000 +0900
> @@ -324,7 +324,6 @@ config SHMOBILE_IOMMU_L1SIZE
> 
>  config IPMMU_VMSA
>  	bool "Renesas VMSA-compatible IPMMU"
> -	depends on ARM_LPAE
>  	depends on ARCH_SHMOBILE || COMPILE_TEST
>  	select IOMMU_API
>  	select IOMMU_IO_PGTABLE_LPAE

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency Magnus Damm <magnus.damm@gmail.com> - 2015-10-19 05:10 +0200
  Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-10-19 08:50 +0200
    Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency Magnus Damm <magnus.damm@gmail.com> - 2015-10-20 11:00 +0200
      Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-10-20 12:30 +0200
  Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency Joerg Roedel <joro@8bytes.org> - 2015-10-23 12:00 +0200

csiph-web