Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1252546

Re: [PATCH 4/5] perf, tools: Print branch filter state with -vv

Show all headers | View raw

On Tue, Oct 20, 2015 at 03:51:35PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 20, 2015 at 11:46:36AM -0700, Andi Kleen escreveu:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > Add a missing field to the perf_event_attr debug output.
> 
> Thanks, applied.

> > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> > index e8724b4..2b75d56 100644
> > --- a/tools/perf/util/evsel.c
> > +++ b/tools/perf/util/evsel.c
> > @@ -1232,6 +1232,7 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr,
> >  	PRINT_ATTRf(config, p_hex);
> >  	PRINT_ATTRn("{ sample_period, sample_freq }", sample_period, p_unsigned);
> >  	PRINT_ATTRf(sample_type, p_sample_type);
> > +	PRINT_ATTRf(branch_sample_type, p_unsigned);
> >  	PRINT_ATTRf(read_format, p_read_format);
> >  
> >  	PRINT_ATTRf(disabled, p_unsigned);

That's the wrong place.. it should be between config2 and
sample_regs_user.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] perf, tools: Print branch filter state with -vv Andi Kleen <andi@firstfloor.org> - 2015-10-20 20:50 +0200
  Re: [PATCH 4/5] perf, tools: Print branch filter state with -vv Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-20 21:00 +0200
    Re: [PATCH 4/5] perf, tools: Print branch filter state with -vv Peter Zijlstra <peterz@infradead.org> - 2015-10-21 10:30 +0200
  [tip:perf/core] perf evsel: Print branch filter state with -vv tip-bot for Andi Kleen <tipbot@zytor.com> - 2015-10-22 11:30 +0200

csiph-web