Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1251971

[PATCH] mm: initialize kmem_cache pointer to NULL

Show all headers | View raw

The assignment to NULL within the error condition was written
in a 2014 patch to suppress a compiler warning.
However it would be cleaner to just initialize the kmem_cache
to NULL and just return it in case of an error condition.

Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com>
---
 mm/slab_common.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/slab_common.c b/mm/slab_common.c
index 5ce4fae..cf0b7bb 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -384,7 +384,7 @@ struct kmem_cache *
 kmem_cache_create(const char *name, size_t size, size_t align,
 		  unsigned long flags, void (*ctor)(void *))
 {
-	struct kmem_cache *s;
+	struct kmem_cache *s = NULL;
 	const char *cache_name;
 	int err;
 
@@ -396,7 +396,6 @@ kmem_cache_create(const char *name, size_t size, size_t align,
 
 	err = kmem_cache_sanity_check(name, size);
 	if (err) {
-		s = NULL;	/* suppress uninit var warning */
 		goto out_unlock;
 	}
 
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: initialize kmem_cache pointer to NULL Alexandru Moise <00moses.alexander00@gmail.com> - 2015-10-20 21:10 +0200
  Re: [PATCH] mm: initialize kmem_cache pointer to NULL Christoph Lameter <cl@linux.com> - 2015-10-20 22:10 +0200
  Re: [PATCH] mm: initialize kmem_cache pointer to NULL David Rientjes <rientjes@google.com> - 2015-10-21 22:40 +0200

csiph-web