Re: [PATCH v2] mmc: core: Allow specifying current consumption

From	Bjorn Andersson <bjorn.andersson@sonymobile.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mmc: core: Allow specifying current consumption
Date	2015-10-17 19:20 +0200
Message-ID	<qkDjb-41n-9@gated-at.bofh.it> (permalink)
References	<pHhYt-7rP-1@gated-at.bofh.it> <qiWgj-7NK-25@gated-at.bofh.it> <qkcM2-6LS-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 16 Oct 05:55 PDT 2015, Ulf Hansson wrote:

> On 13 October 2015 at 03:00, Bjorn Andersson
> <bjorn.andersson@sonymobile.com> wrote:
> > This allows us to specify expected current consumption of the vmmc and
> > vqmmc regulators. This is needed to bring the supplying regulators out
> > of their low-power-mode while accessing the mmc.
> 
> This indeed makes sense, still I need to think a bit more on this.
> 

Thanks.

We can currently work around this by using "regulator-system-load" on
the vmmc regulator, but a proper fix would be nice.

> For example, can we allow these regulators to enter low power again at
> some times? If so, when and what should that current value be.
> 

The regulator framework recalculates the total load on a regulator upon
enable/disable, but currently it doesn't depend on the state of the
regulator.

I talked to Mark about this a while back and he was positive to us
correcting this, so disabled regulators wouldn't count towards the total
load of a regulator. (So that still is on my todo)

The second option would be to do what is done in the Qualcomm codeaurora
kernels, where the regulators are never disabled and there's a smaller
current specified for the suspend case.

This would require bigger changes to the mmc core I presume, but the
naming of the dt properties support such future adaption.

> Moreover, wouldn't vmmc|vqmmc-active-current be depending what eMMC/SD
> card that is attached?
> 

I would say so, I do however not know how to acquire or encode that
information. Any suggestions here are welcome.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] mmc: core: Allow specifying current consumption Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-10-13 03:10 +0200
  Re: [PATCH v2] mmc: core: Allow specifying current consumption Ulf Hansson <ulf.hansson@linaro.org> - 2015-10-16 15:00 +0200
    Re: [PATCH v2] mmc: core: Allow specifying current consumption Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-10-17 19:20 +0200

csiph-web