Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1246824

Re: [PATCH] crypto/pkcs7_verify: Fix unaligned access in pkcs7_verify()

Show all headers | View raw

On Tue, Oct 13, 2015 at 10:54:01AM -0400, Sowmini Varadhan wrote:
> 
> On sparc, we see unaligned access messages on each modprobe[-r]:
> 
> Kernel unaligned access at TPC[6ad9b4] pkcs7_verify [..]
> Kernel unaligned access at TPC[6a5484] crypto_shash_finup [..]
> Kernel unaligned access at TPC[6a5390] crypto_shash_update [..]
> Kernel unaligned access at TPC[10150308] sha1_sparc64_update [..]
> Kernel unaligned access at TPC[101501ac] __sha1_sparc64_update [..]
> 
> These ware triggered by mod_verify_sig() invocations of pkcs_verify(), and
> are are being caused by an unaligned desc at (sha1, digest_size is 0x14)
>         desc = digest + digest_size;
> 
> To fix this, pkcs7_verify needs to make sure that desc is pointing
> at an aligned value past the digest_size, and kzalloc appropriately,
> taking alignment values into consideration.
> 
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>

Patch applied.  Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] crypto/pkcs7_verify: Fix unaligned access in pkcs7_verify() Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-13 17:00 +0200
  Re: [PATCH] crypto/pkcs7_verify: Fix unaligned access in  pkcs7_verify() Herbert Xu <herbert@gondor.apana.org.au> - 2015-10-14 16:30 +0200
  Re: [PATCH] crypto/pkcs7_verify: Fix unaligned access in pkcs7_verify() David Howells <dhowells@redhat.com> - 2015-10-15 17:20 +0200

csiph-web