Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1246383
| From | tip-bot for Oleksij Rempel <tipbot@zytor.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [tip:irq/core] irqchip/mxs: Panic if ioremap or domain creation fails |
| Date | 2015-10-14 09:50 +0200 |
| Message-ID | <qjoYW-ib-43@gated-at.bofh.it> (permalink) |
| References | <qiQNA-8hD-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Commit-ID: e59a8451be1162d5a10a33e40092f1796cb8fdca
Gitweb: http://git.kernel.org/tip/e59a8451be1162d5a10a33e40092f1796cb8fdca
Author: Oleksij Rempel <linux@rempel-privat.de>
AuthorDate: Mon, 12 Oct 2015 21:15:30 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 14 Oct 2015 09:37:47 +0200
irqchip/mxs: Panic if ioremap or domain creation fails
Current code will only warn and then dereference the NULL pointer or
continue, which results in a fatal NULL pointer dereference later.
If the initialization fails, the machine is unusable, so panic right
away.
[ tglx: Massaged changelog and picked the irqdomain panic from the
next patch]
Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
Tested-by: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: marc.zyngier@arm.com
Cc: jason@lakedaemon.net
Link: http://lkml.kernel.org/r/1444677334-12242-2-git-send-email-linux@rempel-privat.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-mxs.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index 604df63..96148a7 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -97,7 +97,8 @@ static int __init icoll_of_init(struct device_node *np,
struct device_node *interrupt_parent)
{
icoll_base = of_iomap(np, 0);
- WARN_ON(!icoll_base);
+ if (!icoll_base)
+ panic("%s: unable to map resource", np->full_name);
/*
* Interrupt Collector reset, which initializes the priority
@@ -107,6 +108,9 @@ static int __init icoll_of_init(struct device_node *np,
icoll_domain = irq_domain_add_linear(np, ICOLL_NUM_IRQS,
&icoll_irq_domain_ops, NULL);
- return icoll_domain ? 0 : -ENODEV;
+ if (!icoll_domain)
+ panic("%s: unable to create irqdomain", np->full_name);
+
+ return 0;
}
IRQCHIP_DECLARE(mxs, "fsl,icoll", icoll_of_init);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v5 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support Thomas Gleixner <tglx@linutronix.de> - 2015-10-09 16:20 +0200
[PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel <linux@rempel-privat.de> - 2015-10-10 15:10 +0200
Re: [PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Thomas Gleixner <tglx@linutronix.de> - 2015-10-11 20:00 +0200
Re: [PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel <linux@rempel-privat.de> - 2015-10-12 11:30 +0200
Re: [PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Thomas Gleixner <tglx@linutronix.de> - 2015-10-12 11:40 +0200
[PATCH v6 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel <linux@rempel-privat.de> - 2015-10-12 21:20 +0200
[PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel <linux@rempel-privat.de> - 2015-10-12 21:20 +0200
[PATCH v7 2/3] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel <linux@rempel-privat.de> - 2015-10-12 21:20 +0200
[tip:irq/core] irqchip/mxs: Prepare driver for hardware with different offsets tip-bot for Oleksij Rempel <tipbot@zytor.com> - 2015-10-14 09:50 +0200
[PATCH v7 1/3] ARM: irqchip: mxs: do panic if icoll_base == NULL Oleksij Rempel <linux@rempel-privat.de> - 2015-10-12 21:20 +0200
[tip:irq/core] irqchip/mxs: Panic if ioremap or domain creation fails tip-bot for Oleksij Rempel <tipbot@zytor.com> - 2015-10-14 09:50 +0200
[PATCH v7 3/3] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel <linux@rempel-privat.de> - 2015-10-12 21:20 +0200
[tip:irq/core] irqchip/mxs: Add Alphascale ASM9260 support tip-bot for Oleksij Rempel <tipbot@zytor.com> - 2015-10-14 09:50 +0200
[PATCH v7 0/3] Add support for ASM9260 interrupt controller Oleksij Rempel <linux@rempel-privat.de> - 2015-10-12 21:20 +0200
[PATCH v6 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel <linux@rempel-privat.de> - 2015-10-10 15:10 +0200
[PATCH v6 0/2] Add support for ASM9260 interrupt controller Oleksij Rempel <linux@rempel-privat.de> - 2015-10-10 15:10 +0200
csiph-web