Re: [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer

From	AKASHI Takahiro <takahiro.akashi@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer
Date	2015-10-14 07:10 +0200
Message-ID	<qjmu5-5eE-5@gated-at.bofh.it> (permalink)
References	<qhgj9-iz-21@gated-at.bofh.it> <qhgj9-iz-29@gated-at.bofh.it> <qj9Gz-28L-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/14/2015 12:24 AM, Jungseok Lee wrote:
> On Oct 8, 2015, at 7:01 PM, AKASHI Takahiro wrote:
>
> Hi Akashi,
>
>> Function graph tracer modifies a return address (LR) in a stack frame
>> to hook a function return. This will result in many useless entries
>> (return_to_handler) showing up in a stack tracer's output.
>>
>> This patch replaces such entries with originals values preserved in
>> current->ret_stack[].
>>
>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>
> The following diff should be folded into this patch, not [7/7] one, to
> address build breakage.

Thanks.
I fixed all the build errors reported by kbuild test robot.

-Takahiro AKASHI

> ----8<----
> diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
> index 407991b..7126d4d 100644
> --- a/arch/arm64/kernel/stacktrace.c
> +++ b/arch/arm64/kernel/stacktrace.c
> @@ -17,6 +17,7 @@
>    */
>   #include <linux/kernel.h>
>   #include <linux/export.h>
> +#include <linux/ftrace.h>
>   #include <linux/sched.h>
>   #include <linux/stacktrace.h>
> ----8<----
>
> Best Regards
> Jungseok Lee
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer AKASHI Takahiro <takahiro.akashi@linaro.org> - 2015-10-08 12:10 +0200
  Re: [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer Jungseok Lee <jungseoklee85@gmail.com> - 2015-10-13 17:30 +0200
    Re: [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under  function graph tracer AKASHI Takahiro <takahiro.akashi@linaro.org> - 2015-10-14 07:10 +0200

csiph-web