Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245369

Re: [PATCH v2] thp: use is_zero_pfn only after pte_present check

Show all headers | View raw

On Mon, Oct 12, 2015 at 10:41:24PM -0700, Greg Kroah-Hartman wrote:
> On Tue, Oct 13, 2015 at 11:38:38AM +0900, Minchan Kim wrote:
> > Use is_zero_pfn on pteval only after pte_present check on pteval
> > (It might be better idea to introduce is_zero_pte where checks
> > pte_present first). Otherwise, it could work with swap or
> > migration entry and if pte_pfn's result is equal to zero_pfn
> > by chance, we lose user's data in __collapse_huge_page_copy.
> > So if you're luck, the application is segfaulted and finally you
> > could see below message when the application is exit.
> > 
> > BUG: Bad rss-counter state mm:ffff88007f099300 idx:2 val:3
> > 
> > Cc: <stable@vger.kernel.org>
> > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> > Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > ---
> > Hello Greg,
> > 
> > This patch should go to -stable but when you will apply it
> > after merging of linus tree, it will be surely conflicted due
> > to userfaultfd part.
> > 
> > I want to know how to handle it.
> 
> You will get an automated email saying it didn't apply and then you
> provide a backported version.  Or you send a properly backported version
> to stable@vger.kernel.org before then, with the git commit id of the
> patch in Linus's tree.

Okay, I will send a right version when I received automatd email.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] thp: use is_zero_pfn only after pte_present check Minchan Kim <minchan@kernel.org> - 2015-10-13 05:00 +0200
  Re: [PATCH v2] thp: use is_zero_pfn only after pte_present check Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-10-13 08:00 +0200
    Re: [PATCH v2] thp: use is_zero_pfn only after pte_present check Minchan Kim <minchan@kernel.org> - 2015-10-13 08:30 +0200
  Re: [PATCH v2] thp: use is_zero_pfn only after pte_present check Vlastimil Babka <vbabka@suse.cz> - 2015-10-13 09:30 +0200
    Re: [PATCH v2] thp: use is_zero_pfn only after pte_present check Minchan Kim <minchan@kernel.org> - 2015-10-13 11:10 +0200

csiph-web