Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244134

Re: [PATCH] iio: mxs-lradc: Fix temperature offset

Show all headers | View raw

On 07/10/15 00:13, Marek Vasut wrote:
> On 10/06/2015 16:22, Alexandre Belloni wrote:
>> 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset.
>>
>> Reported-by: Janusz Użycki <j.uzycki@elpromaelectronics.com>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> Nice find :-)
> 
> Acked-by: Marek Vasut <marex@denx.de>
Ah, missed this when applying.  Have added your Ack to the V2 and will
push it out later.

J
> 
> (I am using different MUA, please pardon the possible issues)
> 
>> ---
>>   drivers/staging/iio/adc/mxs-lradc.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
>> index 3f7715c9968b..67bfa54c4fb1 100644
>> --- a/drivers/staging/iio/adc/mxs-lradc.c
>> +++ b/drivers/staging/iio/adc/mxs-lradc.c
>> @@ -916,10 +916,10 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
>>           if (chan->type == IIO_TEMP) {
>>               /* The calculated value from the ADC is in Kelvin, we
>>                * want Celsius for hwmon so the offset is
>> -             * -272.15 * scale
>> +             * -273.15 * scale
>>                */
>> -            *val = -1075;
>> -            *val2 = 691699;
>> +            *val = -1079;
>> +            *val2 = 644268;
>>
>>               return IIO_VAL_INT_PLUS_MICRO;
>>           }
>>
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iio: mxs-lradc: Fix temperature offset Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-10-06 16:30 +0200
  Re: [PATCH] iio: mxs-lradc: Fix temperature offset Stefan Wahren <stefan.wahren@i2se.com> - 2015-10-06 20:50 +0200
    Re: [PATCH] iio: mxs-lradc: Fix temperature offset Marek Vasut <marex@denx.de> - 2015-10-07 01:20 +0200
      Re: [PATCH] iio: mxs-lradc: Fix temperature offset Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-10-07 02:50 +0200
        Re: [PATCH] iio: mxs-lradc: Fix temperature offset Stefan Wahren <stefan.wahren@i2se.com> - 2015-10-07 09:20 +0200
          Re: [PATCH] iio: mxs-lradc: Fix temperature offset Marek Vasut <marex@denx.de> - 2015-10-08 23:20 +0200
  Re: [PATCH] iio: mxs-lradc: Fix temperature offset Marek Vasut <marex@denx.de> - 2015-10-07 01:20 +0200
    Re: [PATCH] iio: mxs-lradc: Fix temperature offset Jonathan Cameron <jic23@kernel.org> - 2015-10-11 16:10 +0200

csiph-web