Re: [PATCH 2/2] clk: tegra: delete unneeded of_node_put

From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] clk: tegra: delete unneeded of_node_put
Date	2015-10-12 21:00 +0200
Message-ID	<qiQue-7F7-33@gated-at.bofh.it> (permalink)
References	<qhK7v-Tp-3@gated-at.bofh.it> <qhK7w-Tp-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/09, Julia Lawall wrote:
> for_each_child_of_node performs an of_node_put on each iteration, so
> putting an of_node_put before a continue results in a double put.
> 
> The semantic match that finds this problem is as follows
> (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
> 
>  for_each_child_of_node(root, child) {
>    ... when != of_node_get(child)
> *  of_node_put(child);
>    ...
> *  continue;
> }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] delete unneeded of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-09 20:00 +0200
  [PATCH 2/2] clk: tegra: delete unneeded of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-09 20:00 +0200
    Re: [PATCH 2/2] clk: tegra: delete unneeded of_node_put Stephen Boyd <sboyd@codeaurora.org> - 2015-10-12 21:00 +0200

csiph-web