Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244855

Re: [PATCH v4 11/25] ARM/dmaengine: edma: Merge the two drivers under drivers/dma/

Show all headers | View raw

On Thu, Sep 24, 2015 at 01:01:58PM +0300, Peter Ujfalusi wrote:
> Move the code out from arch/arm/common and merge it inside of the dmaengine
> driver.
> This change is done with as minimal change to the code as possible to avoid
> any possibilities to introducing regression.

Is this a pure move patch or code has been modified, if latter am
disappointed that existing code style issue have not been fixed


> +static inline void edma_write(struct edma_cc *ecc, int offset, int val)
> +{
> +	__raw_writel(val, ecc->base + offset);
> +}
> +static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and,
> +			       unsigned or)

This looks bad on my 80 char screen, and few more places below

> +{
> +	unsigned val = edma_read(ecc, offset);

checkpatch should have asked you to add empty line here, many places below
too

> +	val &= and;
> +	val |= or;
> +	edma_write(ecc, offset, val);
> +}

empty line here and few more places

More later :)

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 11/25] ARM/dmaengine: edma: Merge the two drivers  under drivers/dma/ Vinod Koul <vinod.koul@intel.com> - 2015-10-12 18:00 +0200
  Re: [PATCH v4 11/25] ARM/dmaengine: edma: Merge the two drivers under  drivers/dma/ Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-10-13 11:00 +0200
    Re: [PATCH v4 11/25] ARM/dmaengine: edma: Merge the two drivers under  drivers/dma/ Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-10-13 12:40 +0200

csiph-web