Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1243555

Re: [PATCH v4 3/6] iommu: add ARM short descriptor page table allocator.

From Robin Murphy <robin.murphy@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 3/6] iommu: add ARM short descriptor page table allocator.
Date 2015-10-09 19:50 +0200
Message-ID <qhJXP-HL-11@gated-at.bofh.it> (permalink)
References (1 earlier) <pTlai-fp-25@gated-at.bofh.it> <q9nhO-vs-49@gated-at.bofh.it> <q9IPg-6Ov-9@gated-at.bofh.it> <qbwAi-7K8-13@gated-at.bofh.it> <qhIfn-6C3-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 09/10/15 16:57, Will Deacon wrote:
> On Tue, Sep 22, 2015 at 03:12:47PM +0100, Yong Wu wrote:
>>       I would like to show you a problem I met, The recursion here may
>> lead to stack overflow while we test FHD video decode.
>>
>>      From the log, I get the internal variable in the error case: the
>> "size" is 0x100000, the "iova" is 0xfea00000, but at that time the
>> "blk_size" is 0x1000 as it was the map of small-page. so it enter the
>> recursion here.
>>
>>      After check the unmap flow, there is only a iommu_unmap in
>> __iommu_dma_unmap, and it won't check the physical address align in
>> iommu_unmap.
>
> That sounds like a bug in __iommu_dma_unmap. Robin?

Isn't it just cf27ec930be9 again wearing different trousers? All I do is 
call iommu_unmap with the same total size that was mapped originally.

Robin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v4 3/6] iommu: add ARM short descriptor page table  allocator. Will Deacon <will.deacon@arm.com> - 2015-10-09 18:00 +0200
  Re: [PATCH v4 3/6] iommu: add ARM short descriptor page table  allocator. Robin Murphy <robin.murphy@arm.com> - 2015-10-09 19:50 +0200
    Re: [PATCH v4 3/6] iommu: add ARM short descriptor page table  allocator. Will Deacon <will.deacon@arm.com> - 2015-10-09 20:20 +0200

csiph-web