Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239990

Re: [PATCH v2 1/2] irqchip: sunxi-nmi: Use driver name instead of DT node name for identification

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Oct 06, 2015 at 12:42:13AM +0800, Chen-Yu Tsai wrote:
> The device tree node name is typically "interrupt-controller", which is
> rather useless when used in printk messages and irq chip names for
> identification purposes. Use the driver name "sunxi-nmi" instead.
> 
> While at it move the identifier from pr_err() calls to the pr_fmt macro.
> 
> Also remove the "__func__" identifier from the error message in the
> interrupt type setting callback, sunxi_sc_nmi_set_type(). The driver
> name in the pr_fmt macro should be enough.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] irqchip: sunxi-nmi: Use driver name instead of DT node name for identification Chen-Yu Tsai <wens@csie.org> - 2015-10-05 18:50 +0200
  Re: [PATCH v2 1/2] irqchip: sunxi-nmi: Use driver name instead of DT  node name for identification Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-06 00:10 +0200
  [tip:irq/core] irqchip/sunxi-nmi:   Use driver name instead of DT node name for identification tip-bot for Chen-Yu Tsai <tipbot@zytor.com> - 2015-10-09 23:00 +0200

csiph-web