Re: [PATCH] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC

From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC
Date	2015-10-05 20:20 +0200
Message-ID	<qgiwG-6GP-5@gated-at.bofh.it> (permalink)
References	<qbXAu-4LB-19@gated-at.bofh.it> <qeHpw-6S6-3@gated-at.bofh.it> <qeQj7-3kO-1@gated-at.bofh.it> <qeRoS-56r-25@gated-at.bofh.it> <qg6c9-5Ti-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/05, Rajendra Nayak wrote:
> []...
> 
> >>> It would also be nicer if this parent/child relationship can
> >>> somehow be represented in data (struct gdsc) that gets passed to
> >>> the gdsc driver which then sets it up, instead of individual
> >>> clock drivers doing it.
> >>
> >> Agreed. I'd rather that we do nothing besides register domains
> >> and then let the core code handle hooking up domains and
> >> subdomains.
> > 
> > A little closer inspection makes me want to skip this. PM domains
> > can have multiple "master" domains, and pm_genpd_init() is the
> > only API that would be able to do the linking. That API is mostly
> > about initializing things to default values, so it doesn't seem
> > like a good fit. I'll send a v2 with the remove part and the
> > exports.
> 
> What I was suggesting is that the qcom gdsc driver handle this
> instead of the qcom clock drivers.
> Something like..

Ah ok. This patch will still need the gdscs to be in a certain
order though so that we don't add a subdomain on an uninitialized
domain. So I guess some list of pointer pairs to call the
function on could be done in the qcom_cc_desc structure if we
need to do this more than a couple times.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC Stephen Boyd <sboyd@codeaurora.org> - 2015-09-23 21:10 +0200
  Re: [PATCH] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC Rajendra Nayak <rnayak@codeaurora.org> - 2015-10-01 10:30 +0200
    Re: [PATCH] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC Stephen Boyd <sboyd@codeaurora.org> - 2015-10-01 20:00 +0200
      Re: [PATCH] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC Stephen Boyd <sboyd@codeaurora.org> - 2015-10-01 21:10 +0200
        Re: [PATCH] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC Rajendra Nayak <rnayak@codeaurora.org> - 2015-10-05 07:10 +0200
          Re: [PATCH] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC Stephen Boyd <sboyd@codeaurora.org> - 2015-10-05 20:20 +0200

csiph-web