Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1238882

[PATCH 21/24] ver_linux: sh-utils.patch

Show all headers | View raw

Using 'awk' here is a bit of an overkill. Should the output of 'expr --v'
vary on another disto, or change overtime, it may no longer be available
in the last field, as relied on by the current implementation.
I believe 'sed' offers greater flexibility here in terms of processing
varying output as well as being more light-weight.


Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1
Arch Linux
openSuSE 13.2

Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
--- linux/scripts/ver_linux.orig    2015-10-03 13:41:57.118790241 +0300
+++ linux/scripts/ver_linux    2015-10-03 14:00:24.812214544 +0300
@@ -85,7 +85,13 @@
 oprofiled --version 2>&1 | awk \
 '(NR==1 && ($2 == "oprofile")) {print "oprofile              ", $3}'

-expr --v 2>&1 | awk 'NR==1{print "Sh-utils              ", $NF}'
+test -x "$expr" &&
+$expr --v 2>&1 |
+sed '
+    /^expr/!d
+    s/[^0-9.]//g
+    s/^/Sh-utils\t\t/
+'

 udevinfo -V 2>&1 | grep version | awk '{print "udev                  ", $3}'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 21/24] ver_linux: sh-utils.patch Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2015-10-03 15:50 +0200

csiph-web