Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1238736

Re: [PATCH 1/3] Input: db9 - store object at correct index

Show all headers | View raw

On Fri, Oct 02, 2015 at 11:11:18AM -0700, Dmitry Torokhov wrote:
> Hi Sudip,
> 
> On Fri, Oct 02, 2015 at 04:58:33PM +0530, Sudip Mukherjee wrote:
> > The variable i is used to check the port to attach to and we are
> > supposed to save the reference of struct db9 in the location given by
> > db9_base[i]. But after finding out the index i is getting modified again
> > so we saved in a wrong index.
> > 
> > Fixes: 2260c419b52b ("Input: db9 - use parallel port device model")
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> >  drivers/input/joystick/db9.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/input/joystick/db9.c b/drivers/input/joystick/db9.c
> > index cf1f602..f6ecd4a 100644
> > --- a/drivers/input/joystick/db9.c
> > +++ b/drivers/input/joystick/db9.c
> > @@ -560,7 +560,7 @@ static void db9_attach(struct parport *pp)
> >  	const struct db9_mode_data *db9_mode;
> >  	struct pardevice *pd;
> >  	struct input_dev *input_dev;
> > -	int i, j;
> > +	int i, j, k;
> >  	int mode;
> >  	struct pardev_cb db9_parport_cb;
> >  
> > @@ -577,6 +577,7 @@ static void db9_attach(struct parport *pp)
> >  		pr_debug("Not using parport%d.\n", pp->number);
> >  		return;
> >  	}
> > +	k = i;
> 
> Hmm, I'd prefer we did not reuse 'i' at all. Can we instead of 'k' add
> 'port_idx' and use it instead of 'i' in the first loop?
Yes, that will be great. This reuse of i caused this mistake. Sorry
about that I should have been more carefull.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] Input: db9 - store object at correct index Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-02 13:30 +0200
  Re: [PATCH 1/3] Input: db9 - store object at correct index Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-02 20:20 +0200
    Re: [PATCH 1/3] Input: db9 - store object at correct index Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-03 07:50 +0200

csiph-web