Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1236705

Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while requesting the PWM"

Show all headers | View raw

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> This reverts commit 68feaca0b13e453aa14ee064c1736202b48b342f.
> This commit breaks legacy platforms, for which :
>  (a) no pwm table is added (legacy platforms)
>  (b) in this case, in pwm_get(), pmw_lookup_list is empty, and therefore
>      chosen == NULL, and therefore pwm_get() returns NULL, and pwm_get()
>      returns -EPROBE_DEFER
>  (c) as a consequence, this code is unreachable in pwm_bl.c :
>      if (IS_ERR(pb->pwm)) {
> 	ret = PTR_ERR(pb->pwm);
>  	dev_info(&pdev->dev, "%s:%d(): %d\n", __func__, __LINE__, ret);
>  	if (ret == -EPROBE_DEFER)
>  		goto err_alloc;
>
>  	dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n");
>  	pb->legacy = true;
>  	pb->pwm = pwm_request(data->pwm_id, "pwm-backlight");
>
> As this code is unreachable, all legacy platforms relying on pwm_id are
> broken, amongst which pxa have been tested as broken.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Thierry, would you have a look please ?
As I said before, all legacy platform relying on pwm_id are broken. I'd like to
be sure this lands in the next -rc series.

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while requesting the PWM" Robert Jarzmik <robert.jarzmik@free.fr> - 2015-09-26 21:40 +0200
  Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while requesting the PWM" Robert Jarzmik <robert.jarzmik@free.fr> - 2015-09-30 21:40 +0200
    Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while  requesting the PWM" Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-10-01 10:10 +0200
      Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while requesting the PWM" Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-01 11:20 +0200
      Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while requesting the PWM" Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-01 19:50 +0200
      Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while  requesting the PWM" Thierry Reding <thierry.reding@gmail.com> - 2015-10-05 11:40 +0200
        Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while  requesting the PWM" Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-05 13:20 +0200
          Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while  requesting the PWM" Thierry Reding <thierry.reding@gmail.com> - 2015-10-05 15:00 +0200
            Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while  requesting the PWM" Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-05 15:40 +0200
              Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while  requesting the PWM" Thierry Reding <thierry.reding@gmail.com> - 2015-10-05 16:10 +0200
                Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while  requesting the PWM" Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-05 17:30 +0200

csiph-web