Re: [PATCH net] net: dsa: fix preparation of a port STP update

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] net: dsa: fix preparation of a port STP update
Date	2015-09-30 06:40 +0200
Message-ID	<qehln-2JC-3@gated-at.bofh.it> (permalink)
References	<qe7YJ-6an-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Tue, 29 Sep 2015 14:17:54 -0400

> Because of the default 0 value of ret in dsa_slave_port_attr_set, a
> driver may return -EOPNOTSUPP from the commit phase of a STP state,
> which triggers a WARN() from switchdev.
> 
> This happened on a 6185 switch which does not support hardware bridging.
> 
> Fixes: 3563606258cf ("switchdev: convert STP update to switchdev attr set")
> Reported-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] net: dsa: fix preparation of a port STP update Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-09-29 20:40 +0200
  Re: [PATCH net] net: dsa: fix preparation of a port STP update David Miller <davem@davemloft.net> - 2015-09-30 06:40 +0200

csiph-web