Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1235707

[PATCH 1/3] perf record: Allocate area for sample_id_hdr in a synthesized comm event

Show all headers | View raw

A previous patch added a synthesized comm event for forked child
process but it missed that the event should contain area for
sample_id_hdr at the end.  It worked by accident since the perf_event
union contains bigger event structs like mmap_events.

This patch fixes it by dynamically allocating event struct including
those area like in perf_event__synthesize_thread_map().

Reported-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-record.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index a01c8ae1ee07..5e01c070dbf2 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -637,17 +637,25 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
 	 * Let the child rip
 	 */
 	if (forks) {
-		union perf_event event;
+		union perf_event *event;
+
+		event = malloc(sizeof(event->comm) + machine->id_hdr_size);
+		if (event == NULL) {
+			err = -ENOMEM;
+			goto out_child;
+		}
+
 		/*
 		 * Some H/W events are generated before COMM event
 		 * which is emitted during exec(), so perf script
 		 * cannot see a correct process name for those events.
 		 * Synthesize COMM event to prevent it.
 		 */
-		perf_event__synthesize_comm(tool, &event,
+		perf_event__synthesize_comm(tool, event,
 					    rec->evlist->workload.pid,
 					    process_synthesized_event,
 					    machine);
+		free(event);
 
 		perf_evlist__start_workload(rec->evlist);
 	}
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] perf record: Allocate area for sample_id_hdr in a synthesized comm event Namhyung Kim <namhyung@kernel.org> - 2015-09-30 04:00 +0200
  [PATCH 3/3] perf top: Register idle thread Namhyung Kim <namhyung@kernel.org> - 2015-09-30 04:00 +0200
    [tip:perf/core] perf top: Register idle thread tip-bot for Namhyung Kim <tipbot@zytor.com> - 2015-10-03 09:50 +0200
  Re: [PATCH 1/3] perf record: Allocate area for sample_id_hdr in a  synthesized comm event Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-01 00:10 +0200
  [tip:perf/core] perf record:   Allocate area for sample_id_hdr in a synthesized comm event tip-bot for Namhyung Kim <tipbot@zytor.com> - 2015-10-03 09:50 +0200

csiph-web