Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1237497

[PATCH v2 0/2] perf tool: improve error handling in perf_flag_probe()

Show all headers | View raw

Hi,

Following the EBUSY errors reported by Jiri Olsa [1], I've tryed to
improve a bit the way perf_flag_probe() handle errors.

In case EBUSY is returned by perf_event_open(), testing the function
again without PERF_FLAG_FD_CLOEXEC is meaningless: EBUSY is not
related to close-on-exec flag, so there's nothing to confirm.

For other errors, not yet explicitly handled by perf_flag_probe(),
it's pointless to report a second error message for the same error
code: the second check should not print an error if the error is
the same as the one returned for the first check.

Changes from v1 [2]:
 - resend

Changes from v0 [3]:
 - rebased on top of commit 48536c9195ae ("perf tools: Fix probing for PERF_FLAG_FD_CLOEXEC flag");
 - update a bit commit message;
 - the previous patchset was acked by Jiri[4], but I haven't
   reported Acked-by: in this updated patchset.

[1] http://lkml.kernel.org/r/1406908014-8312-1-git-send-email-jolsa@kernel.org
[2] http://lkml.kernel.org/r/cover.1425901229.git.ydroneaud@opteya.com
[3] http://lkml.kernel.org/r/cover.1410595700.git.ydroneaud@opteya.com
[4] http://lkml.kernel.org/r/20140920121438.GB15481@krava.brq.redhat.com

Yann Droneaud (2):
  perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY
    error
  perf tools: report PERF_FLAG_FD_CLOEXEC probing error once

 tools/perf/util/cloexec.c | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] perf tool: improve error handling in perf_flag_probe() Yann Droneaud <ydroneaud@opteya.com> - 2015-10-01 17:20 +0200
  [PATCH v2 2/2] perf tools: report PERF_FLAG_FD_CLOEXEC probing error once Yann Droneaud <ydroneaud@opteya.com> - 2015-10-01 17:20 +0200
    Re: [PATCH v2 2/2] perf tools: report PERF_FLAG_FD_CLOEXEC probing  error once Yann Droneaud <ydroneaud@opteya.com> - 2015-10-02 15:50 +0200
  [PATCH v2 1/2] perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY error Yann Droneaud <ydroneaud@opteya.com> - 2015-10-01 17:20 +0200
    Re: [PATCH v2 1/2] perf tools: shortcut PERF_FLAG_FD_CLOEXEC  probing in case of EBUSY error Yann Droneaud <ydroneaud@opteya.com> - 2015-10-01 23:40 +0200
      Re: [PATCH v2 1/2] perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing  in case of EBUSY error Jiri Olsa <jolsa@redhat.com> - 2015-10-02 15:20 +0200

csiph-web