Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1234746

Re: [PATCH 4/5] watchdog: implement error handling in lockup_detector_suspend()

From Aaron Tomlin <atomlin@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 4/5] watchdog: implement error handling in lockup_detector_suspend()
Date 2015-09-29 08:50 +0200
Message-ID <qdWTE-792-3@gated-at.bofh.it> (permalink)
References <qdNx0-23T-15@gated-at.bofh.it> <qdNx1-23T-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Mon 2015-09-28 22:44 +0200, Ulrich Obergfell wrote:
> lockup_detector_suspend() now handles errors from watchdog_park_threads().
> 
> Signed-off-by: Ulrich Obergfell <uobergfe@redhat.com>
> ---
>  kernel/watchdog.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 457113c..3bc22a9 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -707,6 +707,11 @@ int lockup_detector_suspend(void)
>  
>  	if (ret == 0)
>  		watchdog_suspended++;
> +	else {
> +		watchdog_disable_all_cpus();
> +		pr_err("Failed to suspend lockup detectors, disabled\n");
> +		watchdog_enabled = 0;
> +	}
>  
>  	mutex_unlock(&watchdog_proc_mutex);
>  

Reviewed-by: Aaron Tomlin <atomlin@redhat.com>

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 4/5] watchdog: implement error handling in lockup_detector_suspend() Ulrich Obergfell <uobergfe@redhat.com> - 2015-09-28 22:50 +0200
  Re: [PATCH 4/5] watchdog: implement error handling in  lockup_detector_suspend() Aaron Tomlin <atomlin@redhat.com> - 2015-09-29 08:50 +0200

csiph-web