[PATCH] overlayfs: Pass O_LARGEFILE unconditionally in ovl_copy_up_data()

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH] overlayfs: Pass O_LARGEFILE unconditionally in ovl_copy_up_data()
Date	2015-09-28 16:20 +0200
Message-ID	<qdHrA-1Q9-9@gated-at.bofh.it> (permalink)
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Pass O_LARGEFILE unconditionally in ovl_copy_up_data() as it's purely for
catching 32-bit userspace dealing with a file large enough that it'll be
mishandled if the application isn't aware that there might be an integer
overflow.  Inside the kernel, there shouldn't be any problems.

Reported-by: Ulrich Obergfell <uobergfe@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/overlayfs/copy_up.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index d3a5990fd2b9..871fcb67be97 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs/copy_up.c
@@ -76,19 +76,16 @@ static int ovl_copy_up_data(struct path *old, struct path *new, loff_t len)
 	struct file *new_file;
 	loff_t old_pos = 0;
 	loff_t new_pos = 0;
-	int error = 0, o_flag = 0;
+	int error = 0;
 
 	if (len == 0)
 		return 0;
 
-	if (i_size_read(d_inode(old->dentry)) > MAX_NON_LFS)
-		o_flag |= O_LARGEFILE;
-	
-	old_file = ovl_path_open(old, o_flag | O_RDONLY);
+	old_file = ovl_path_open(old, O_LARGEFILE | O_RDONLY);
 	if (IS_ERR(old_file))
 		return PTR_ERR(old_file);
 
-	new_file = ovl_path_open(new, o_flag | O_WRONLY);
+	new_file = ovl_path_open(new, O_LARGEFILE | O_WRONLY);
 	if (IS_ERR(new_file)) {
 		error = PTR_ERR(new_file);
 		goto out_fput;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] overlayfs: Pass O_LARGEFILE unconditionally in  ovl_copy_up_data() David Howells <dhowells@redhat.com> - 2015-09-28 16:20 +0200

csiph-web