Re: [PATCH v3] zbud: allow up to PAGE_SIZE allocations

From	Minchan Kim <minchan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] zbud: allow up to PAGE_SIZE allocations
Date	2015-09-25 09:50 +0200
Message-ID	<qcvVv-3pb-1@gated-at.bofh.it> (permalink)
References	<qcud3-Y6-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 25, 2015 at 07:57:53AM +0200, Vitaly Wool wrote:
> From e219a88f4cd68842e7e04e37461aba6e06555d6a Mon Sep 17 00:00:00 2001
> From: Vitaly Vul <vitaly.vul@sonymobile.com>
> Date: Tue, 22 Sep 2015 14:07:01 +0200
> Subject: [PATCH] zbud: allow up to PAGE_SIZE allocations
> 
> Currently zbud is only capable of allocating not more than
> PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as
> long as only zswap is using it, but other users of zbud may
> (and likely will) want to allocate up to PAGE_SIZE. This patch
> addresses that by skipping the creation of zbud internal
> structure in the beginning of an allocated page. As a zbud page
> is no longer guaranteed to contain zbud header, the following
> changes have to be applied throughout the code:
> * page->lru to be used for zbud page lists
> * page->private to hold 'under_reclaim' flag
> 
> page->private will also be used to indicate if this page contains
> a zbud header in the beginning or not ('headless' flag).
> 
> This patch incorporates minor fixups after Seth's comments.
> 
> Signed-off-by: Vitaly Wool <vitalywool@gmail.com>

In previous thread, I saw this patch is part of "support zbud into zram"
and commented out several times but have been ignored.
So, what I can do is just

Nacked-by: Minchan Kim <minchan@kernel.org>




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] zbud: allow up to PAGE_SIZE allocations Vitaly Wool <vitalywool@gmail.com> - 2015-09-25 08:00 +0200
  Re: [PATCH v3] zbud: allow up to PAGE_SIZE allocations Minchan Kim <minchan@kernel.org> - 2015-09-25 09:50 +0200

csiph-web