Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx
Date	2015-09-24 18:30 +0200
Message-ID	<qchzb-8ls-5@gated-at.bofh.it> (permalink)
References	<qcg0p-61m-1@gated-at.bofh.it> <qcg0q-61m-13@gated-at.bofh.it> <qcgD7-70f-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 24/09/2015 at 17:22:54 +0200, Peter Rosin wrote :
> I just noticed that other ports have the same problem in sama5d3.dtsi. E.g.
> 
> 	uart1 {
> 		pinctrl_uart1: uart1-0 {
> 			atmel,pins =
> 				<AT91_PIOA 30 AT91_PERIPH_B AT91_PINCTRL_NONE   /* conflicts with TWD0, ISI_VSYNC */
> 				 AT91_PIOA 31 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>;      /* conflicts with TWCK0, ISI_HSYNC */
> 		};
> 	};
> 
> Given that the original bug I found spread all over the map, it seems
> like someone was confused when the pull-ups were originally added.
> Someone (else?) at Atmel needs to audit this so that pull-ups are
> added on the rx-pins instead of the tx-pins.
> 

Sure, that is the plan!
Thanks again for the report.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-24 16:50 +0200
  Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx Peter Rosin <peda@lysator.liu.se> - 2015-09-24 17:30 +0200
    Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-24 18:30 +0200

csiph-web