Re: [PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors
Date	2015-09-25 23:20 +0200
Message-ID	<qcIzo-4Ol-5@gated-at.bofh.it> (permalink)
References	<qbyLM-2nO-29@gated-at.bofh.it> <qbz58-2KT-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday, September 22, 2015 09:51:27 AM Stephen Boyd wrote:
> On 09/22, Viresh Kumar wrote:
> > of_property_count_u32_elems() will never return 0, but a -ve error value
> > of a positive count. And so the current !count check is wrong.
> > 
> > Also, a missing "opp-microvolt" property isn't a problem and so we need
> > to do of_find_property() separately to confirm that.
> > 
> > Fixes: 274659029c9d ("PM / OPP: Add support to parse "operating-points-v2" bindings")
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> 
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

Applied, thanks!

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-22 18:40 +0200
  Re: [PATCH V2] PM / OPP: of_property_count_u32_elems() can return  errors Stephen Boyd <sboyd@codeaurora.org> - 2015-09-22 19:00 +0200
    Re: [PATCH V2] PM / OPP: of_property_count_u32_elems() can return errors "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 23:20 +0200

csiph-web