Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue
Date	2015-09-22 06:10 +0200
Message-ID	<qbn3X-2tL-5@gated-at.bofh.it> (permalink)
References	<qa7ND-Xy-1@gated-at.bofh.it> <qb5A7-2vD-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Mon, Sep 21, 2015 at 10:21:31AM +0100, Felipe Tonello wrote:
> Hi Balbi,
> 
> On Fri, Sep 18, 2015 at 6:36 PM,  <eu@felipetonello.com> wrote:
> > From: "Felipe F. Tonello" <eu@felipetonello.com>
> >
> > f_midi is not checking whether there is an error on usb_ep_queue
> > request, ignoring potential problems, such as memory leaks.
> >
> > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> > ---
> >
> > Changes for v2:
> >   - Update code style.
> >
> > Changes for v3:
> >   - Use ip_ep instead of out_ep. Fixed typo in commit message.
> 
> I forgot to add v3 to the patch subject, so it queued here instead. Do
> you want me to re-send as v3?

you need to ask Peter, he's the chipidea maintainer. Peter ?

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue eu@felipetonello.com - 2015-09-18 19:40 +0200
  Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue Felipe Tonello <eu@felipetonello.com> - 2015-09-21 11:30 +0200
    Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue Felipe Balbi <balbi@ti.com> - 2015-09-22 06:10 +0200

csiph-web