Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231659

Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, 2015-09-23 at 11:05 -0700, David Miller wrote:
> From: Ivan Mikhaylov <ivan@ru.ibm.com>
> Date: Wed, 23 Sep 2015 14:42:22 +0400
> 
> > Register dump out work preventing with 
> > old ethtool + new driver and new ethtool + old driver.
> 
> First of all you didn't provide a proper Signoff.
> 
> Second of all, there was so much discussion about whether this does
> or does not break things for various combinations of old/new ethtool
> and kernel.
> 
> Therefore I want a real detailed commit message that explains why this
> is all OK.  After so much confusion and discussion, providing a patch
> with absolutely no commit message is completely inappropriate.

I would suggest something like this:

"""
The size of the MAC register dump used to be the size specified by the
reg property in the device tree.  Userland has no good way of finding
out that size, and it was not specified consistently for each MAC type,
so ethtool would end up printing junk at the end of the register dump
if the device tree didn't match the size it assumed.

Using the new version numbers indicates unambiguously that the size of
the MAC register dump is dependent only on the MAC type.

Fixes: 5369c71f7ca2 ("net/ibm/emac: fix size of emac dump memory areas")
"""

Also:

Acked-by: Ben Hutchings <ben@decadent.org.uk>

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net/ibm/emac: bump version numbers for correct work with  ethtool Ivan Mikhaylov <ivan@ru.ibm.com> - 2015-09-23 13:50 +0200
  Re: [PATCH] net/ibm/emac: bump version numbers for correct work  with ethtool David Miller <davem@davemloft.net> - 2015-09-23 20:10 +0200
    Re: [PATCH] net/ibm/emac: bump version numbers for correct work  with ethtool Ben Hutchings <ben@decadent.org.uk> - 2015-09-23 21:10 +0200
    Re: [PATCH] net/ibm/emac: bump version numbers for correct work  with ethtool Ivan Mikhaylov <ivan@ru.ibm.com> - 2015-09-25 07:10 +0200
      Re: [PATCH] net/ibm/emac: bump version numbers for correct work  with ethtool David Miller <davem@davemloft.net> - 2015-09-25 08:00 +0200
        Re: [PATCH] net/ibm/emac: bump version numbers for correct work  with ethtool Ivan Mikhaylov <ivan@ru.ibm.com> - 2015-09-25 11:00 +0200

csiph-web