Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed

From	Baoquan He <bhe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed
Date	2015-09-23 02:30 +0200
Message-ID	<qbG6B-4AP-3@gated-at.bofh.it> (permalink)
References	<qbuf8-4hk-15@gated-at.bofh.it> <qbBTk-6Qf-23@gated-at.bofh.it> <qbFNf-4eK-11@gated-at.bofh.it> <qbFNf-4eK-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/22/15 at 05:08pm, Andrew Morton wrote:
> On Wed, 23 Sep 2015 08:02:55 +0800 Baoquan He <bhe@redhat.com> wrote:
> 
> > > 
> > > >  	}
> > > >  
> > > >  	low_base = memblock_find_in_range(low_size, (1ULL<<32),
> > > >  					low_size, alignment);
> > > >  
> > > >  	if (!low_base) {
> > > > -		if (!auto_set)
> > > > -			pr_info("crashkernel low reservation failed - No suitable area found.\n");
> > > > -
> > > > -		return;
> > > > +		pr_info("crashkernel low reservation failed - No suitable area found.\n");
> > > 
> > > That's not a terribly useful message.  If kdump is now unavailable and
> > > the operator needs to take some remedial action then we should inform
> > > them of this.
> > > 
> > > Also, such a message should have higher severity than KERN_INFO?
> > 
> > Yes, how about KERN_ERR? It's an unexpected result from kdump side
> > though it doesn't harm the normal kernel.
> 
> Sure, KERN_ERR is good.  Along with more useful message text.

OK, will do. Thanks for your suggestion.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-22 13:50 +0200
  Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel  low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-22 16:00 +0200
  Re: [Patch v4] Do not reserve crashkernel high memory if  crashkernel low memory reserving failed Andrew Morton <akpm@linux-foundation.org> - 2015-09-22 22:00 +0200
    Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel  low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-23 02:10 +0200
      Re: [Patch v4] Do not reserve crashkernel high memory if  crashkernel low memory reserving failed Andrew Morton <akpm@linux-foundation.org> - 2015-09-23 02:10 +0200
        Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel  low memory reserving failed Baoquan He <bhe@redhat.com> - 2015-09-23 02:30 +0200

csiph-web