Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231048

[PATCH v3 2/6] PCI: generic: Only fixup irqs for bus we are creating.

Show all headers | View raw

From: David Daney <david.daney@cavium.com>

If we create multiple buses with pci-host-generic, or there are buses
created by other drivers, we don't want to call pci_fixup_irqs() which
operates on all devices, not just the devices on the bus being added.
The consequence is that either the fixups are done more than once, or
in some cases incorrect fixups could be applied.

Call pci_bus_fixup_irqs() instead of pci_fixup_irqs().

Signed-off-by: David Daney <david.daney@cavium.com>
---
No change from v2.

Changes from v1: Moved most of the code to pci_bus_fixup_irqs(),
making this patch very simple.

 drivers/pci/host/pci-host-generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pci-host-generic.c b/drivers/pci/host/pci-host-generic.c
index 265dd25..9e9f1c3 100644
--- a/drivers/pci/host/pci-host-generic.c
+++ b/drivers/pci/host/pci-host-generic.c
@@ -262,7 +262,7 @@ static int gen_pci_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
+	pci_bus_fixup_irqs(bus, pci_common_swizzle, of_irq_parse_and_map_pci);
 
 	if (!pci_has_flag(PCI_PROBE_ONLY)) {
 		pci_bus_size_bridges(bus);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/6] PCI: generic: Misc. bug fixes/enhancements David Daney <ddaney.cavm@gmail.com> - 2015-09-23 02:00 +0200
  [PATCH v3 2/6] PCI: generic: Only fixup irqs for bus we are creating. David Daney <ddaney.cavm@gmail.com> - 2015-09-23 02:00 +0200
  [PATCH v3 4/6] PCI: generic: Correct, and avoid overflow, in bus_max calculation. David Daney <ddaney.cavm@gmail.com> - 2015-09-23 02:00 +0200
    Re: [PATCH v3 4/6] PCI: generic: Correct, and avoid overflow, in bus_max calculation. Arnd Bergmann <arnd@arndb.de> - 2015-09-23 10:10 +0200
      Re: [PATCH v3 4/6] PCI: generic: Correct, and avoid overflow, in bus_max calculation. Arnd Bergmann <arnd@arndb.de> - 2015-09-23 21:40 +0200
  [PATCH v3 3/6] PCI: generic: Quit clobbering our pci_ops. David Daney <ddaney.cavm@gmail.com> - 2015-09-23 02:00 +0200
    Re: [PATCH v3 3/6] PCI: generic: Quit clobbering our pci_ops. Arnd Bergmann <arnd@arndb.de> - 2015-09-23 10:30 +0200
  Re: [PATCH v3 0/6] PCI: generic: Misc. bug fixes/enhancements Arnd Bergmann <arnd@arndb.de> - 2015-09-23 10:10 +0200

csiph-web