Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1230729

Re: [PATCH 2/2] staging: dgap: remove unused variable

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] staging: dgap: remove unused variable
Date 2015-09-22 20:50 +0200
Message-ID <qbANA-5hQ-17@gated-at.bofh.it> (permalink)
References <q78Ge-vY-7@gated-at.bofh.it> <q78Ge-vY-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Sep 10, 2015 at 05:24:59PM +0530, Sudip Mukherjee wrote:
> Removed them but kept one call to ioread8() as it might affect the
> hardware.

Just leave the extra variable until someone has the hardware and can
verify the right fix.  Static checker warnings are good, don't silence
them just to silence them.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 2/2] staging: dgap: remove unused variable Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-22 20:50 +0200

csiph-web