Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1229187

[PATCH v3 3/4] usb: dwc2: fix unbalanced phy control

From Marek Szyprowski <m.szyprowski@samsung.com>
Newsgroups linux.kernel
Subject [PATCH v3 3/4] usb: dwc2: fix unbalanced phy control
Date 2015-09-21 12:20 +0200
Message-ID <qb6mu-3FW-29@gated-at.bofh.it> (permalink)
References <qb6mt-3FW-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Even when DWC2 is in (internal) suspended state, it should disable PHY
in suspend and then enable it in resume. This patch fixes unbalanced PHY
control sequence.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/usb/dwc2/platform.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index 3d1f82d..f8ab538 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -290,8 +290,6 @@ static int __maybe_unused dwc2_suspend(struct device *dev)
 	if (dwc2_is_device_mode(dwc2)) {
 		ret = dwc2_hsotg_suspend(dwc2);
 	} else {
-		if (dwc2->lx_state == DWC2_L0)
-			return 0;
 		phy_exit(dwc2->phy);
 		phy_power_off(dwc2->phy);
 
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v3 0/4] Exynos4412-based Trats2 USB gadget (DWC2) fixes Marek Szyprowski <m.szyprowski@samsung.com> - 2015-09-21 12:20 +0200
  [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to  platform.c Marek Szyprowski <m.szyprowski@samsung.com> - 2015-09-21 12:20 +0200
  [PATCH v3 3/4] usb: dwc2: fix unbalanced phy control Marek Szyprowski <m.szyprowski@samsung.com> - 2015-09-21 12:20 +0200

csiph-web