Re: [PATCH 3/3] add support for DWC UFS Host Controller

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] add support for DWC UFS Host Controller
Date	2016-02-08 17:20 +0100
Message-ID	<qZWHF-7Fq-47@gated-at.bofh.it> (permalink)
References	(4 earlier) <qY80A-3RT-35@gated-at.bofh.it> <qYuX9-4mU-35@gated-at.bofh.it> <qZVLA-74r-7@gated-at.bofh.it> <qZW4W-7bA-17@gated-at.bofh.it> <qZW4W-7bA-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 08, 2016 at 03:36:52PM +0000, Joao Pinto wrote:
> Hi Mark,
> 
> On 2/8/2016 3:30 PM, Mark Rutland wrote:
> > On Mon, Feb 08, 2016 at 03:17:11PM +0000, Joao Pinto wrote:
> >> Hi Mark and Arnd,
> >> Are you saying that a user that puts "snps,ufshcd-1.1"
> >> in the DT compatibility string disables the UFS 2.0 in the core driver despite
> >> the controller is 2.0? Please clarify.
> > 
> > If you can consistently and safely detect that the HW is 2.0, using 2.0
> > functionality is fine.
> > 
> > Regardless, you should have a -1.1 compatible string for the 1.1 HW, and
> > a -2.0 string for the 2.0 HW, so that DTs are explicit about what the
> > hardware is. If 2.0 is intended to be a superset of 1.1, you can have a
> > 1.1 fallback entry for the 2.0 hardware.
> > 
> 
> Ok, I will include the version in the compatibility strings, but if someone
> mentions "snps,ufshcd-1.1" only and the driver detects that the HW is 2.0
> capable it will activate the 2.0 features independently of what mentioned in the
> DT, correct?

As above, if that can be detected safely and reliably, then I don't see
a problem with that.

Thanks,
Mark.

Thread

[PATCH 0/3] add support for DWC UFS Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-03 12:30 +0100
  [PATCH 1/3] fixed typo in ufshcd-pltfrm Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-03 12:30 +0100
  [PATCH 3/3] add support for DWC UFS Host Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-03 12:30 +0100
    Re: [PATCH 3/3] add support for DWC UFS Host Controller Arnd Bergmann <arnd@arndb.de> - 2016-02-03 14:00 +0100
      Re: [PATCH 3/3] add support for DWC UFS Host Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-03 16:10 +0100
        Re: [PATCH 3/3] add support for DWC UFS Host Controller Arnd Bergmann <arnd@arndb.de> - 2016-02-03 16:40 +0100
          Re: [PATCH 3/3] add support for DWC UFS Host Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-03 17:00 +0100
            Re: [PATCH 3/3] add support for DWC UFS Host Controller Mark Rutland <mark.rutland@arm.com> - 2016-02-04 17:30 +0100
              Re: [PATCH 3/3] add support for DWC UFS Host Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-08 16:20 +0100
                Re: [PATCH 3/3] add support for DWC UFS Host Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-08 16:40 +0100
                Re: [PATCH 3/3] add support for DWC UFS Host Controller Mark Rutland <mark.rutland@arm.com> - 2016-02-08 17:20 +0100
                Re: [PATCH 3/3] add support for DWC UFS Host Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-08 17:20 +0100
                Re: [PATCH 3/3] add support for DWC UFS Host Controller Mark Rutland <mark.rutland@arm.com> - 2016-02-08 16:40 +0100
          Re: [PATCH 3/3] add support for DWC UFS Host Controller Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-03 18:30 +0100
  [PATCH 2/3] added support for ufs 2.0 Joao Pinto <Joao.Pinto@synopsys.com> - 2016-02-03 12:30 +0100

csiph-web