Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1326921
| From | Petr Mladek <pmladek@suse.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] ftrace/module: remove ftrace module notifier |
| Date | 2016-02-04 16:30 +0100 |
| Message-ID | <qYu14-3JT-9@gated-at.bofh.it> (permalink) |
| References | <qXxNo-38h-5@gated-at.bofh.it> <qXxNo-38h-3@gated-at.bofh.it> <qYs8X-Kq-37@gated-at.bofh.it> <qYsVk-1nc-35@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu 2016-02-04 09:18:01, Steven Rostedt wrote: > On Thu, 4 Feb 2016 14:27:51 +0100 > Petr Mladek <pmladek@suse.com> wrote: > > > > > + ftrace_module_enable(mod); > > > blocking_notifier_call_chain(&module_notify_list, > > > MODULE_STATE_COMING, mod); > > > return 0; > > > > Also we need to call ftrace_release_mod() in bug_cleanup: > > goto target in load_module(). Otherwise, it will stay > > enabled when, e.g. parse_args() fails. > > Look farther down (after free_module:), it's already there. Ah, I see. ftrace_release_mod() is called there on an unexpected location. Error paths typically do actions in the reverse order in compare with the normal paths :-) Thanks for the pointer, Petr
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/2] ftrace/module: remove ftrace module notifier Jessica Yu <jeyu@redhat.com> - 2016-02-02 02:20 +0100
Re: [PATCH v2 1/2] ftrace/module: remove ftrace module notifier Petr Mladek <pmladek@suse.com> - 2016-02-04 14:30 +0100
Re: [PATCH v2 1/2] ftrace/module: remove ftrace module notifier Steven Rostedt <rostedt@goodmis.org> - 2016-02-04 15:20 +0100
Re: [PATCH v2 1/2] ftrace/module: remove ftrace module notifier Petr Mladek <pmladek@suse.com> - 2016-02-04 16:30 +0100
Re: [PATCH v2 1/2] ftrace/module: remove ftrace module notifier Steven Rostedt <rostedt@goodmis.org> - 2016-02-04 16:40 +0100
csiph-web