Re: sched/core: WARNING in __might_sleep

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: sched/core: WARNING in __might_sleep
Date	2016-02-01 12:50 +0100
Message-ID	<qXl9v-207-1@gated-at.bofh.it> (permalink)
References	<qXkGu-1Kt-9@gated-at.bofh.it> <qXkGu-1Kt-7@gated-at.bofh.it> <qXkQa-1OW-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 01, 2016 at 12:26:06PM +0100, Johannes Berg wrote:
> On Mon, 2016-02-01 at 12:13 +0100, Peter Zijlstra wrote:
> > 
> > Yeah, from the rfkill code, which you failed to CC.
> 
> Thanks Peter :)
> 
> > In any case, this is a fail in the rfkill code, which should be
> > sorted
> > with the below patch (but the rfkill people should double check), and
> > ideally they'd use list_empty_careful() instead of the mutex, but I
> > don't know their code well enough to say if that's safe or not.
> 
> Even list_empty() is fine in this case since we go and recheck it
> anyway in the calling loop, while the mutex is held.
> 
> I have commit 6736fde9672f on its way to mainline.

OK, that looks good. Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: sched/core: WARNING in __might_sleep Peter Zijlstra <peterz@infradead.org> - 2016-02-01 12:20 +0100
  Re: sched/core: WARNING in __might_sleep Johannes Berg <johannes@sipsolutions.net> - 2016-02-01 12:30 +0100
    Re: sched/core: WARNING in __might_sleep Peter Zijlstra <peterz@infradead.org> - 2016-02-01 12:50 +0100

csiph-web