Re: [RESEND PATCH v2 10/16] clk: move checking .git_parent to __clk_core_init()

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH v2 10/16] clk: move checking .git_parent to __clk_core_init()
Date	2016-02-03 03:20 +0100
Message-ID	<qXVd0-45u-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <qXxu2-2HC-9@gated-at.bofh.it> <qXyT7-3SA-3@gated-at.bofh.it> <qXz2P-3Wf-45@gated-at.bofh.it> <qXzct-3ZH-1@gated-at.bofh.it> <qXQ3E-93-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Stephen,


2016-02-03 5:43 GMT+09:00 Stephen Boyd <sboyd@codeaurora.org>:
> On 02/02, Masahiro Yamada wrote:
>> 2016-02-02 11:39 GMT+09:00 Stephen Boyd <sboyd@codeaurora.org>:
>> >
>> > Right, this patch moves the check to __clk_core_init(), and it
>> > will print an error and then keep going (because we lost the goto
>> > out part). Once we keep going in __clk_core_init() we'll call
>> > __clk_init_parent() and NULL pointer deref.
>> >
>>
>> Ah, I missed that.
>>
>> We need
>>
>>    ret = -EINVAL;
>>    goto out;
>>
>> here, I think.
>>
>> Shall I send the v3 for 08/16?
>>
>> Or, if it is too late, shall I send a fix-up patch?
>>
>
> I'll split the patch out again and squash in those two lines.
> Nothing more to do. Thanks.


Thank you very much for taking care of all of them!



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RESEND PATCH v2 10/16] clk: move checking .git_parent to  __clk_core_init() Stephen Boyd <sboyd@codeaurora.org> - 2016-02-02 02:00 +0100
  Re: [RESEND PATCH v2 10/16] clk: move checking .git_parent to __clk_core_init() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-02 03:30 +0100
    Re: [RESEND PATCH v2 10/16] clk: move checking .git_parent to  __clk_core_init() Stephen Boyd <sboyd@codeaurora.org> - 2016-02-02 03:40 +0100
      Re: [RESEND PATCH v2 10/16] clk: move checking .git_parent to __clk_core_init() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-02 03:50 +0100
        Re: [RESEND PATCH v2 10/16] clk: move checking .git_parent to  __clk_core_init() Stephen Boyd <sboyd@codeaurora.org> - 2016-02-02 21:50 +0100
          Re: [RESEND PATCH v2 10/16] clk: move checking .git_parent to __clk_core_init() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-03 03:20 +0100

csiph-web