[PATCH] ovl: copy new uid/gid into overlayfs runtime inode

From	Konstantin Khlebnikov <koct9i@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] ovl: copy new uid/gid into overlayfs runtime inode
Date	2016-01-31 14:30 +0100
Message-ID	<qX0eK-3SI-19@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Overlayfs must update uid/gid after chown, otherwise functions
like inode_owner_or_capable() will check user against stale uid.
Catched by xfstests generic/087, it chowns file and calls utimes.

Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
---
 fs/overlayfs/inode.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index 49e204560655..a4ff5d0d7db9 100644
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -65,6 +65,8 @@ int ovl_setattr(struct dentry *dentry, struct iattr *attr)
 
 		inode_lock(upperdentry->d_inode);
 		err = notify_change(upperdentry, attr, NULL);
+		if (!err)
+			ovl_copyattr(upperdentry->d_inode, dentry->d_inode);
 		inode_unlock(upperdentry->d_inode);
 	}
 	ovl_drop_write(dentry);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] ovl: copy new uid/gid into overlayfs runtime inode Konstantin Khlebnikov <koct9i@gmail.com> - 2016-01-31 14:30 +0100

csiph-web