Re: [PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed

From	Tomi Valkeinen <tomi.valkeinen@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed
Date	2016-01-27 08:10 +0100
Message-ID	<qVsoN-8kL-11@gated-at.bofh.it> (permalink)
References	<qVgH1-88L-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 26/01/16 20:37, Dan Williams wrote:
> pfn_t_to_page() honors the flags in the pfn_t value to determine if a
> pfn is backed by a page.  However, vm_insert_mixed() was originally
> written to use pfn_valid() to make this determination.  To restore the
> old/correct behavior, ignore the pfn_t flags in the !pfn_t_devmap() case
> and fallback to trusting pfn_valid().
> 
> Fixes: 01c8f1c44b83 ("mm, dax, gpu: convert vm_insert_mixed to pfn_t")

Thanks, this fixes the crash with omapdrm.

Tested-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

 Tomi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed Dan Williams <dan.j.williams@intel.com> - 2016-01-26 19:40 +0100
  Re: [PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed Dan Williams <dan.j.williams@intel.com> - 2016-01-26 21:40 +0100
  Re: [PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-01-27 08:10 +0100

csiph-web