Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318463

Re: [PATCH] lib/bug: make panic_on_warn available for all architectures

Show all headers | View raw

On Fri, 22 Jan 2016 14:12:16 +0100 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> Christian Borntraeger reported that panic_on_warn doesn't have any
> effect on s390.
> 
> The panic_on_warn feature was introduced with 9e3961a09798 ("kernel:
> add panic_on_warn"). However it did care only for the case when
> WANT_WARN_ON_SLOWPATH is defined. This is turn is only the case for
> architectures which do not have an own __WARN_TAINT defined.
> 
> Other architectures which do have __WARN_TAINT defined call
> report_bug() for warnings within lib/bug.c which does not call panic()
> in case panic_on_warn is set.
> 
> Let's simply enable the panic_on_warn feature by adding the same code
> like it was added to warn_slowpath_common() in panic.c.
> 
> This enables panic_on_warn also for arm64, parisc, powerpc, s390 and
> sh.
> 

It's a bit sad to do this in two places.  You couldn't find a suitable
place which is effective for all architectures?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] lib/bug: make panic_on_warn available for all architectures Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-01-22 14:20 +0100
  Re: [PATCH] lib/bug: make panic_on_warn available for all  architectures Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-22 14:50 +0100
  Re: [PATCH] lib/bug: make panic_on_warn available for all architectures Prarit Bhargava <prarit@redhat.com> - 2016-01-22 15:00 +0100
  Re: [PATCH] lib/bug: make panic_on_warn available for all  architectures Andrew Morton <akpm@linux-foundation.org> - 2016-01-27 00:20 +0100

csiph-web