Re: [PATCH] numa: fix /proc/<pid>/numa_maps for hugetlbfs on s390

From	Michael Holzheu <holzheu@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] numa: fix /proc/<pid>/numa_maps for hugetlbfs on s390
Date	2016-01-26 12:00 +0100
Message-ID	<qV9vR-2Vi-35@gated-at.bofh.it> (permalink)
References	<qUSlk-6Ia-25@gated-at.bofh.it> <qUYh4-2r5-1@gated-at.bofh.it>
Organization	IBM

Show all headers | View raw

On Mon, 25 Jan 2016 14:51:16 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 25 Jan 2016 17:30:42 +0100 Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:
> 
> > When working with hugetlbfs ptes (which are actually pmds) is not
> > valid to directly use pte functions like pte_present() because the
> > hardware bit layout of pmds and ptes can be different. This is the
> > case on s390. Therefore we have to convert the hugetlbfs ptes first
> > into a valid pte encoding with huge_ptep_get().
> > 
> > Currently the /proc/<pid>/numa_maps code uses hugetlbfs ptes without
> > huge_ptep_get(). On s390 this leads to the following two problems:
> > 
> > 1) The pte_present() function returns false (instead of true) for
> >    PROT_NONE hugetlb ptes. Therefore PROT_NONE vmas are missing
> >    completely in the "numa_maps" output.
> > 
> > 2) The pte_dirty() function always returns false for all hugetlb ptes.
> >    Therefore these pages are reported as "mapped=xxx" instead of
> >    "dirty=xxx".
> > 
> > Therefore use huge_ptep_get() to correctly convert the hugetlb ptes.
> 
> I'm aiming this at 4.5 only.  Please let me know if you think that a
> -stable backport is warranted.

S390 has NUMA support since kernel 4.3, therefore:

Cc: stable@vger.kernel.org # v4.3+ 

Michael

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] numa: fix /proc/<pid>/numa_maps for hugetlbfs on s390 Michael Holzheu <holzheu@linux.vnet.ibm.com> - 2016-01-25 17:40 +0100
  Re: [PATCH] numa: fix /proc/<pid>/numa_maps for hugetlbfs on s390 Andrew Morton <akpm@linux-foundation.org> - 2016-01-26 00:00 +0100
    Re: [PATCH] numa: fix /proc/<pid>/numa_maps for hugetlbfs on s390 Michael Holzheu <holzheu@linux.vnet.ibm.com> - 2016-01-26 12:00 +0100

csiph-web