Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1317223

Re: [PATCH] clocksource: select CLKSRC_MMIO where needed

Show all headers | View raw

Hi Arnd,

On Mon, Jan 25, 2016 at 05:02:49PM +0100, Arnd Bergmann wrote:
> The Tegra clocksource implementation uses the clocksource_mmio helper
> functions, but currently can be configured without them, which fails:
> 
> drivers/clocksource/built-in.o: In function `tegra20_init_timer':
> :(.init.text+0xac): undefined reference to `clocksource_mmio_init'
> :(.init.text+0x140): undefined reference to `clocksource_mmio_readl_up'
> 
> The same problem exists for Digicolor:
> 
> drivers/clocksource/built-in.o: In function `digicolor_timer_init':
> :(.init.text+0xfa): undefined reference to `clocksource_mmio_init'
> :(.init.text+0x14c): undefined reference to `clocksource_mmio_readl_down'
> 
> I've inspected the Kconfig file to look for other cases that I have not
> yet run into, and added an explicit 'select' to each one to ensure we
> can successfully link the drivers.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

For Digicolor:

Acked-by: Baruch Siach <baruch@tkos.co.il>

Thanks,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clocksource: select CLKSRC_MMIO where needed Arnd Bergmann <arnd@arndb.de> - 2016-01-25 17:10 +0100
  Re: [PATCH] clocksource: select CLKSRC_MMIO where needed Baruch Siach <baruch@tkos.co.il> - 2016-01-25 20:20 +0100
  [tip:timers/urgent] clocksource: Select CLKSRC_MMIO where needed tip-bot for Arnd Bergmann <tipbot@zytor.com> - 2016-01-26 16:50 +0100

csiph-web