Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1317151

Re: [PATCH v1] block: fix bio splitting on max sectors

Show all headers | View raw

On 01/25/2016 07:13 AM, Stefan Haberland wrote:
> Am 23.01.2016 um 04:44 schrieb Jens Axboe:
>> On 01/22/2016 05:05 PM, Ming Lei wrote:
>>> After commit e36f62042880(block: split bios to maxpossible length),
>>> bio can be splitted in the middle of a vector entry, then it
>>> is easy to split out one bio which size isn't aligned with block
>>> size, especially when the block size is bigger than 512.
>>>
>>> This patch fixes the issue by making the max io size aligned
>>> to logical block size.
>>>
>>> Fixes: e36f62042880(block: split bios to maxpossible length)
>>> Reported-by: Stefan Haberland <sth@linux.vnet.ibm.com>
>>> Cc: Keith Busch <keith.busch@intel.com>
>>> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
>>> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
>>> ---
>>> V1:
>>>     - avoid double shift as suggested by Linus
>>>     - compute 'max_sectors' once as suggested by Keith
>>
>> This looks good to me, I'll apply and run a bit of local testing.
>>
>
> I applied the patch and it seems to work for DASD devices. I will do
> some more testing but for me it looks OK.

Thanks for testing, Stefan. It'll go into mainline pretty soon.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1] block: fix bio splitting on max sectors Ming Lei <tom.leiming@gmail.com> - 2016-01-23 01:10 +0100
  Re: [PATCH v1] block: fix bio splitting on max sectors Jens Axboe <axboe@kernel.dk> - 2016-01-23 04:50 +0100
    Re: [PATCH v1] block: fix bio splitting on max sectors Stefan Haberland <sth@linux.vnet.ibm.com> - 2016-01-25 15:20 +0100
      Re: [PATCH v1] block: fix bio splitting on max sectors Jens Axboe <axboe@kernel.dk> - 2016-01-25 19:30 +0100

csiph-web