Re: [PATCH] mtd: nand: mpc5121: use 'of_machine_is_compatible' to simplify code

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: nand: mpc5121: use 'of_machine_is_compatible' to simplify code
Date	2016-01-23 01:40 +0100
Message-ID	<qTUpc-3iD-13@gated-at.bofh.it> (permalink)
References	<qPhZ7-Be-1@gated-at.bofh.it> <qPKeL-2wl-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 11, 2016 at 01:55:58PM +0100, Boris Brezillon wrote:
> On Sun, 10 Jan 2016 07:46:39 +0100
> Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> 
> > The current code is the same as 'of_machine_is_compatible'.
> > So use it in order to remove a few lines of code and to be more
> > consistent with other parts of the kernel.
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> Your patch looks good from a functional POV, but what is this board
> detection hack doing in the NAND driver code in the first place?
> 
> Let's say I didn't see that :-).

:)

> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Applied to l2-mtd.git/next

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mtd: nand: mpc5121: use 'of_machine_is_compatible' to  simplify code Brian Norris <computersforpeace@gmail.com> - 2016-01-23 01:40 +0100

csiph-web