[PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	[PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path
Date	2016-01-22 15:50 +0100
Message-ID	<qTLce-5nI-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

We forgot to remove the clock tree if something goes wrong in ->probe(). Add a
call to intel_lpss_unregister_clock() on error path in ->probe() to fix the
potential issue.

Fixes: 4b45efe85263 (mfd: Add support for Intel Sunrisepoint LPSS devices)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mfd/intel-lpss.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 2a7c6a7..807a3e3 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -455,6 +455,7 @@ int intel_lpss_probe(struct device *dev,
 err_remove_ltr:
 	intel_lpss_debugfs_remove(lpss);
 	intel_lpss_ltr_hide(lpss);
+	intel_lpss_unregister_clock(lpss);
 
 err_clk_register:
 	ida_simple_remove(&intel_lpss_devid_ida, lpss->devid);
-- 
2.7.0.rc3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-22 15:50 +0100
  Re: [PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-01-25 12:00 +0100
  Re: [PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path Lee Jones <lee.jones@linaro.org> - 2016-01-25 13:00 +0100

csiph-web