Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1314816

Re: [PATCH] perf core: Get rid of 'uses dynamic stack allocation' warning

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH] perf core: Get rid of 'uses dynamic stack allocation' warning
Date 2016-01-22 09:10 +0100
Message-ID <qTEX8-1ic-7@gated-at.bofh.it> (permalink)
References <qTDRo-hX-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jan 22, 2016 at 06:52:01AM +0000, Wang Nan wrote:
> On s390 with CONFIG_WARN_DYNAMIC_STACK set, 'uses dynamic stack
> allocation' warning is issued when defining 'struct perf_sample_data'
> local variable.
> 
> This patch suppress this warning by allocating extra 255 bytes and
> compute aligned pointer manually.

I've seen the warning and always wondered wtf it was about. This
Changelog doesn't actually explain what the problem is, so I cannot
judge the solution.

That said, 255 extra bytes does sound excessive just to avoid a warn.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] perf core: Get rid of 'uses dynamic stack allocation' warning Wang Nan <wangnan0@huawei.com> - 2016-01-22 08:00 +0100
  Re: [PATCH] perf core: Get rid of 'uses dynamic stack allocation'  warning kbuild test robot <lkp@intel.com> - 2016-01-22 08:10 +0100
  Re: [PATCH] perf core: Get rid of 'uses dynamic stack allocation'  warning Peter Zijlstra <peterz@infradead.org> - 2016-01-22 09:10 +0100
    Re: [PATCH] perf core: Get rid of 'uses dynamic stack allocation'  warning "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-22 09:10 +0100

csiph-web