Re: [RFC PATCH 1/4] X.509: Fix leap year handling again

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/4] X.509: Fix leap year handling again
Date	2016-01-20 16:20 +0100
Message-ID	<qT2Ic-8li-53@gated-at.bofh.it> (permalink)
References	<qT2Ic-8li-55@gated-at.bofh.it> <qNlDP-14y-3@gated-at.bofh.it> <qNlDQ-14y-19@gated-at.bofh.it> <qT2Ic-8li-55@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Rudolf Polzer <rpolzer@google.com> wrote:

> A small nit: could it be that the month_lengths array also exists elsewhere
> in the kernel?  Can it possibly be shared? A quick glance around didn't pop
> up anything that's not static, so, looks like it's okay to add yet another
> one...

Fair point, but outside of the scope of this patch.  The array already exists
that I'm fixing.  It's definitely material for a future patch though.

Note that the following:

	git grep 'month.*[[]'

trawls up a few candidates.

David

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC PATCH 1/4] X.509: Fix leap year handling again David Howells <dhowells@redhat.com> - 2016-01-20 16:20 +0100

csiph-web