Re: [PATCH 2/3] ASoC: pcm179x: Add I2C interface driver

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] ASoC: pcm179x: Add I2C interface driver
Date	2016-01-19 13:30 +0100
Message-ID	<qSDA5-7Pd-5@gated-at.bofh.it> (permalink)
References	<qSknL-2GX-5@gated-at.bofh.it> <qSknL-2GX-3@gated-at.bofh.it> <qSkH8-33d-17@gated-at.bofh.it> <qSljS-3pb-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jan 18, 2016 at 05:56:57PM +0100, Johan Hovold wrote:
> On Mon, Jan 18, 2016 at 05:14:42PM +0100, Michael Trimarchi wrote:

> > > +       { .compatible = "ti,pcm1792a", },
> > > +       { }
> > > +};
> > > +MODULE_DEVICE_TABLE(of, pcm179x_of_match);

> > can match go in the common part?

> For matching purposes it could, but that would prevent the OF-aliases
> from being defined for the driver modules.

> There are a couple of codec drivers that have taken this route, and it
> works as long as they also define a legacy (e.g. i2c_device_id) table
> that modalias autoloading can fall back to.

> But having having the common module carry the OF-aliases does not seem
> like the right thing to do (e.g. as the common module cannot drive
> anything on its own) even if it avoids a copy of the OF id table.

This does seem like something that the modules code should be able to
cope with - we have a reference from the driver struct to the table
which you'd really expect it to be using.  We already have some issues
there with userspace not handling multiple modaliases terribly well IIRC.

Thread

[PATCH 2/3] ASoC: pcm179x: Add I2C interface driver Jacob Siverskog <jacob@teenage.engineering> - 2016-01-18 17:00 +0100
  Re: [PATCH 2/3] ASoC: pcm179x: Add I2C interface driver Michael Trimarchi <michael@amarulasolutions.com> - 2016-01-18 17:20 +0100
    Re: [PATCH 2/3] ASoC: pcm179x: Add I2C interface driver Johan Hovold <johan@kernel.org> - 2016-01-18 18:00 +0100
      Re: [PATCH 2/3] ASoC: pcm179x: Add I2C interface driver Mark Brown <broonie@kernel.org> - 2016-01-19 13:30 +0100
        Re: [PATCH 2/3] ASoC: pcm179x: Add I2C interface driver Johan Hovold <johan@kernel.org> - 2016-01-19 15:20 +0100
          Re: [PATCH 2/3] ASoC: pcm179x: Add I2C interface driver Mark Brown <broonie@kernel.org> - 2016-01-19 17:40 +0100
            Re: [PATCH 2/3] ASoC: pcm179x: Add I2C interface driver Johan Hovold <johan@kernel.org> - 2016-01-21 12:00 +0100

csiph-web