Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1310951

Re: [git pull] vfs.git regression fix

Show all headers | View raw

On Fri, Jan 15, 2016 at 01:08:44PM -0800, Linus Torvalds wrote:
> On Fri, Jan 15, 2016 at 1:00 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Buggy scripts, actually.  The thing that generates them takes a branch
> > name as argument; turns out that it (pretty much by accident) treats the
> > missing argument as HEAD.  Which tends to give reasonable diffstat and
> > shortlog, so I hadn't spotted the missing check until now.
> 
> You could try "git request-pull". It _used_ to have somewhat similar
> issues, especially when the local branch had not made it to the remote
> point yet, but it should be good now. It actually warns if the remote
> name you give doesn't contain what the local branch contanis etc.

Having checked how git request-pull reacts to missing branch argument...
Very similar bug there - it gives stats for HEAD and URI with no branch
name.  Might've been fixed in later versions (it's 2.1.4 here - debian-stable)

FWIW, the main inconvenience with git request-pull is that it still needs
s/gitolite@ra.kernel.org:/git:\/\/git.kernel.org/ postprocessing.  It mimics
the git push, but the remote you are pushing to probably won't be usable for
pulling by others.  Looks like it would be useful to have something like
	pull_url = git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git
to go with
	url = gitolite@ra.kernel.org:/pub/scm/linux/kernel/git/viro/vfs.git
in .git/config, settable by something in git remote.  OTOH, it's possible to
emulate by setting an extra remote and using git push vfs <...> for pushes,
while doing git request-pull origin vfs-pull <...> for pull requests...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[git pull] vfs.git regression fix Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-15 21:20 +0100
  Re: [git pull] vfs.git regression fix Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-15 21:50 +0100
    Re: [git pull] vfs.git regression fix Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-15 22:10 +0100
      Re: [git pull] vfs.git regression fix Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-15 22:10 +0100
        Re: [git pull] vfs.git regression fix Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-16 14:50 +0100
          Re: [git pull] vfs.git regression fix Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-16 20:10 +0100
          Re: [git pull] vfs.git regression fix Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-01-18 08:50 +0100

csiph-web